Assume maintainership of celery-php

consensus-enterprises / celery-php

PHP client for Celery

http://massivescale.net/celery-php/

Other

0 stars 0 forks source link

Assume maintainership of celery-php #1

Open ergonlogic opened 2 years ago

ergonlogic commented 2 years ago

Per gjedeer/celery-php#125, @gjedeer wrote:

@ergonlogic yeah, I should probably archive this project as it's unmaintained. Maybe one of the forks is kept updated?

If you find something that works for up-to-date celery, let me know please, so that I can tell other users to switch.

My colleagues and I at Consensus are using this package in a FLOSS project, and so could take on at least some minimal maintenance.

To that end, here are some tasks we should probably undertake:

[ ] Enable CI (and ensure that it's passing)
[ ] Publish a new package to Packagist
[ ] Update README and other docs
[ ] Ask @gjedeer to point to this project from gjedeer/celery-php

We generally prefer to work on Gitlab, so we may want to move the project over there, and make this a mirror. This'd effect most of the tasks above, and so should probably be decided first.

gjedeer commented 2 years ago

Glad to see this happen, I'll be happy to cooperate with moving.

By the way, @ergonlogic , you've had commit rights to the old repository for a few years.

jooola commented 2 years ago

Hey, will this fork get it's own name and package (consensus-enterprises/celery-php) ? Or should I grab the package using git directly ?

I've had some trouble with the new amqplib version which renamed some of it's connectors. I also have some issues with the new celery V5 rpc result backend.

I am happy to provide some patches attempts, but I wonder if this project is living ?

Ambient-Impact commented 5 months ago

I think taking over maintainership and using our own namespace for the Composer package like @jooola suggests would be the best way forward. I'm running into a fatal error when trying to upgrade php-amqplib/php-amqplib 2.x to 3.x for Aegir 5 that seems originate with celery-php, which I assume are the same errors @jooola is running into.

Ambient-Impact commented 5 months ago

Alright, so after poking around the php-amqplib/php-amqplib codebase, I realized that AMQPConnection has been deprecated going back to at least 2014, and probably farther back, so just replacing it with AMQPStreamConnection seems to fix the immediate problems and it now seems to work on php-amqplib/php-amqplib:^3.6.2. This should not break compatibility with php-amqplib/php-amqplib:^2.6.

https://github.com/php-amqplib/php-amqplib/commit/64eb289c9f5721daa2bd3ad0f333c5b738580843#diff-f335edbdd39701e7e2a7b44a647a54e0010f15508a06baca2a3db1836549f3eb