Enable downstream libraries to publish to crates.io

consensus-shipyard / ipc

🌳 Spawn multi-level trees of customized, scalable, EVM-compatible networks with IPC. L2++ powered by FVM, Wasm, libp2p, IPFS/IPLD, and CometBFT.

https://ipc.space

Apache License 2.0

42 stars 39 forks source link

Enable downstream libraries to publish to crates.io #1000

Open sanderpick opened 5 months ago

sanderpick commented 5 months ago

We have an SDK that depends on IPC. We'd like to publish this to crates.io at some point.

To enable libraries that depend on IPC to publish to crates.io, all IPC dependencies need to have a version specified. Outstanding git dependencies:

[x] The merkle-tree-rs patch, done in #940.
[ ] libp2p-bitswap = { git = "https://github.com/consensus-shipyard/libp2p-bitswap.git", branch = "chore-upgrade-libipld" }: Looks to be covered by issue #970.
[ ] builtin-actors: I don't see why this couldn't be published. I could open an issue on that repo. We have a custom fork of this, which we'd have to publish as well under some other domain.
[ ] gcra = { git = "https://github.com/consensus-shipyard/gcra-rs.git", branch = "main" }: Could this be absored like what was done in #940 for merkle-tree-rs?

raulk commented 5 months ago

Appreciate the level of detail and analysis on your side, @sanderpick!

consensus-shipyard/libp2p-bitswap

This will require a bit of bandwidth to solve the right way, so I'm +1 on publishing our fork for now and fixing the upstream later in #970.

consensus-shipyard/builtin-actors

I don't think this dependency is actually needed; it might be a leftover from a previous version of the world where IPC actors were being developed as Wasm actors. Let's clean this up.

consensus-shipyard/gcra-rs

Agree with your assessment. We can absorb this utility library as their license is compatible with ours.

raulk commented 5 months ago

@cryptoAtwill could you own absorbing gcra-rs? Should be a quick win!

sanderpick commented 5 months ago

consensus-shipyard/builtin-actors

I don't think this dependency is actually needed; it might be a leftover from a previous version of the world where IPC actors were being developed as Wasm actors. Let's clean this up.

But IPC does use a handful of the builtin-actors. All these fendermint actors use fil_actors_runtime, and the fendermint eam uses fil_actors_evm_shared and fil_actor_eam.