Closed raulk closed 10 months ago
types # former fvm-utils/primitives; these contain basic types; some may move to ipld/types (e.g. Hamt, Cid, etc.)
I agree that they aren't ipc
specific. Where to put this was exactly my question when I first suggested this in https://github.com/filecoin-project/builtin-actors/issues/489
ipld/types
sounds better to me, although we should clean up the error types to remove references to fil_actor_runtime
, which was one of the reasons I never imported these, even though we could use it in fendermint_vm_actor_interfaces
for example.
@raulk What do you mean with "Restore the correct name for the Fendermint Docker image"? Not sure I know exactly what that details
consensus-shipyard/ipc (rename to ipc-libs first, to free up the ipc name)
Note that this will break old issue referencing (i.e. if there's something in the new
ipc-monoreporeferencing
ipc#21`, GH won't be able to redirect and will instead link to a wrong issue). I agree it's the right thing to do, mind you, just something to keep in mind. If we really wanted to preserve this, we should rewrite references first, but it's probably not worth it.
Unrelated: I also went ahead and closed the old GitHub projects, given the move to Linear.
At last, the IPC codebase is in a monorepo -- and the build and CI both work! This issue tracks a bunch of follow-ups to solidify the structure and usage of this repo.
Repos cleanup
ipc-libs
first, to free up theipc
name)ipc
.Build and CI
fendermint
).Ensure we're using caching all throughout (except when publishing?).Non-code reorg
/infra
directory./docs
directory.Code reorg
Update infra scripts
Some infra scripts are outdated, e.g. the current
ipc/scripts/install_infra.sh
still clones fendermint. Need to figure these out in detail.