consento-org / crypto

Crypto primitives for the consento workflow
MIT License
5 stars 1 forks source link

Setup CI system #4

Closed martinheidegger closed 3 years ago

martinheidegger commented 3 years ago

The CI has not been setup for this repo. @dkastl I think the DCO check is missing (i don't know how you added it) and we don't have the tape tests running.

dkastl commented 3 years ago

Good question ... how did I add this DCO bot ...

dkastl commented 3 years ago

Found and added it. It's in the Github organization settings: https://github.com/organizations/consento-org/settings/installations

dkastl commented 3 years ago

The settings are by repository, so every repository we want to add the DCO bot needs to be enabled manually.

martinheidegger commented 3 years ago

@dkastl thanks!

RangerMauve commented 3 years ago

Tests are failing on this line at the moment, but I'll set them up anyway for once it's fixed. 😁

Gonna run them on Linux to start.

RangerMauve commented 3 years ago

What's the DCO bot?

RangerMauve commented 3 years ago

For some reason the actions aren't showing up even though I added the workflow to the repo.

dkastl commented 3 years ago

@RangerMauve , DCO is quickly described here https://github.com/consento-org/.github/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco and is supposed to handle https://developercertificate.org/ . Martin and I thought it's the better alternative to CLA's. We didn't setup the bot on all repositories, because we forgot to do so ;-)

It's quite easy to setup locally, so you won't be asked anymore. Which is also the reason, why we forgot, that some new repositories don't check it ;-)

RangerMauve commented 3 years ago

@martinheidegger I don't think I have permission to enable actions on this repo. Do you think you'll have a chance to either grant them to me or to enable it? 😁

martinheidegger commented 3 years ago

I didn't notice that you don't have permission, enabled permissions for you on this and other repos (manual process?!)

martinheidegger commented 3 years ago

Fixed with 9582c40e6989d184201fb30927c4b2988f7a03df