search

consento-org / mobile

The first (currently alpha) Consento mobile application
https://consento.org
MIT License
14 stars 1 forks source link

Shouldn't be able to delete a vault while asking for consento #66

Open marcchataigner-zz opened 4 years ago

marcchataigner-zz commented 4 years ago

When waiting for a vault to be unlocked, the vault can be deleted. This feature should be disabled at this stage.

Only when the vault is open, the vault can be edited or deleted.

IMG_2611

IMG_2612

martinheidegger commented 4 years ago

From the perspective of the owner of the vault, it should be possible to delete a vault, even ifs not "open-able", right? I mean: it might be the case that the selected lockees are uncooperative, making a certain vault dead. Seems like a good idea to be able to delete it in that case.

What needs to happen though is that any existing request regarding the vault should be cancelled. I.e.: the lockee's should be relieved of their duty and any open request cancelled.

marcchataigner-zz commented 4 years ago

I see. It is true that perhaps I need to make space on my device, no matter what.

What if when I tap the vault in the vault list, it leads to a page with a unlock button. So I don't have to send a request and I may delete the vault.

martinheidegger commented 4 years ago

What if when I tap the vault in the vault list, it leads to a page with a unlock button. So I don't have to send a request and I may delete the vault.

That is possible, and might be an improvement but we may be balancing the common use-case (unlocking) vs. the uncommon use-case (delete) here. As an alternative we could implement a "long-press-for-delete" method in the vault-overview: Pressing for a long time to show a delete icon on the vault or opens an dialog for confirmation of deletion.