conservancy / reimbursinator

Git Up GitHub: https://GiveUpGitHub.org
https://GiveUpGitHub.org
GNU Affero General Public License v3.0
7 stars 6 forks source link

Reports can now be 'submitted', and you cannot modify submitted reports. #92

Closed danieldupriest closed 5 years ago

danieldupriest commented 5 years ago

To test: Attempt actions on Frank's report 27, which is already "submitted".

  1. Start docker (or python manage.py runserver).
  2. From Postman, login as frank@frank.com / frank12345 and copy his authorization into the Collection's auth settings.
  3. Try action Delete Report 27: "Cannot delete a report that has been submitted."
  4. Try action Submit Report 27: "Cannot submit a report that has already been submitted."
  5. Try action Update Section 55: "Cannot update a report that has been submitted."

Finally, login as user@user.com / user12345 from the normal front end, create a new report, fill in a section, save and submit. You should now see the report listed as "view" only, since it is submitted.

Email generation/sending is not yet implemented.

Logan-Oneill commented 5 years ago

Works, but switch the http status codes from 400 to 409.

danieldupriest commented 5 years ago

Changed to 409 errors.