conservation-laws / ryujin

High-performance high-order finite element solver for hyperbolic conservation equations
https://conservation-laws.org
Other
103 stars 25 forks source link

supersonic nozzle #148

Open gregorychristian opened 2 months ago

gregorychristian commented 2 months ago

Simple 2d converging-diverging nozzle setup. All units are in cgs.

ejtovar commented 1 week ago

Hi @gregorychristian, I apologize for the delayed response on this PR. To stay unified with the other files in prm/benchmarks/, would you mind modifying your input file to include some documentation and include a literature reference as well? You can take a look at prm/benchmarks/euler-mach3-cylinder-2d.prm for an example. Also, I don't think we need the .geo file in this PR? Thank you!

tamiko commented 3 days ago

@ejtovar @gregorychristian I wouldn't mind to have the geo file floating around in the repository as well.

gregorychristian commented 3 days ago

Hi @ejtovar @tamiko sorry for the late response, I'll add some documentation in the coming weeks and I also need to normalize/modify some of the units for (u, rho, p).

tamiko commented 2 days ago

@gregorychristian While at it: For Euler it would be more natural to enforce slip boundary conditions (boundary id 2) instead of no-slip boundary conditions (boundary id 3). Would you mind to change that in the mesh?