Closed Gordon01 closed 1 year ago
This fixes https://github.com/console-rs/dialoguer/issues/202 with a well-supported character down to early windows-style utf-16ish
.
The theme looks good and is consistent on different emulators.
Additional testing is needed for: https://github.com/console-rs/dialoguer/issues/149
IMHO, it doesn't look good.
Which new rendering do you think is the worst?
The new VSCode's terminal rendering is questionable.
The same rendering is also used for Mac and Linux, where the X emoji does not look good.
What about '☑' '☒' or '✔' '✘' '☓'
'◌' looks good. I removed the color because some emulators drew it black which is invisible on the default black background. Here are a few screenshots.
windows term:
conhost:
vscode:
black is invisible both in windows term and in conhost.exe:
Linting fails because of: https://github.com/console-rs/dialoguer/pull/209
Feel free to fix it in this PR
Linting and changelog fixed.
Windows Terminal, a widely used terminal emulator for some reason does not support coloring for '✔' char. '✔️' and '❌' may be used instead. They work down to the previous Windows terminal emulator:
conhost.exe
.Before:
Windows Terminal
As you can see, selected and unselected items are indistinguishable.
conhost.exe
Surprisingly, the old windows emulator is better than new one.
VSCode
After:
Windows Terminal
conhost.exe
VSCode