Closed djc closed 1 year ago
Fix a regression from #417 to fix #457.
Of the 4 callers of BarState::tick(), changed three to no longer tick if the ticker is enabled:
BarState::tick()
ProgressBar::inc()
ProgressBar::set_position()
ProgressBar::update()
The fourth is ProgressBar::tick(), which already only ticked if the ticker was disabled.
ProgressBar::tick()
Seems like the performance impact here is negligible (based on running cargo run --release --example fastbar), although it's a little ugly that we have to lock another mutex.
cargo run --release --example fastbar
Fix a regression from #417 to fix #457.
Of the 4 callers of
BarState::tick()
, changed three to no longer tick if the ticker is enabled:ProgressBar::inc()
ProgressBar::set_position()
ProgressBar::update()
The fourth is
ProgressBar::tick()
, which already only ticked if the ticker was disabled.