search

console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.23k stars 240 forks source link

Use `portable-atomic` to fix build on some 32-bit platforms #484

Closed messense closed 1 year ago

messense commented 1 year ago

https://github.com/taiki-e/portable-atomic

Fixes #475

djc commented 1 year ago

I think you missed some imports in the progress_bar module?

djc commented 1 year ago

More in general, do you think it would be feasible to set something up in CI that would let us catch this?

messense commented 1 year ago

I think you missed some imports in the progress_bar module?

AtomicBool isn't a problem and that was used only in tests, but to make it consistent I will change it.

messense commented 1 year ago

More in general, do you think it would be feasible to set something up in CI that would let us catch this?

Added an armv5te test job using cross.

chris-laplante commented 1 year ago

This is great, thanks! @chris-laplante any thoughts?

Looks good to me!

messense commented 1 year ago

Any chance to release a new version soon? Had to downgrade to 0.17 alpha releases to make it build on some 32-bit platforms.

djc commented 1 year ago

See #488.