console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.23k stars 240 forks source link

address a bunch of lints #498

Closed danieleades closed 1 year ago

djc commented 1 year ago

I'd prefer to leave out "avoid using match on bools" and "remove neeedless pass by value", please remove those commits.

Is this clippy at pedantic level or something?

danieleades commented 1 year ago

I'd prefer to leave out "avoid using match on bools" and "remove neeedless pass by value", please remove those commits.

Is this clippy at pedantic level or something?

it's a combination of pedantic and nursery lints, as well as some standard lints triggered by edits made in fixing other lints.

Some of them are just newer lints- the CI job is using the stable clippy version, i'm using nightly

i've dropped those two commits

djc commented 1 year ago

Thanks!