search

console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.36k stars 241 forks source link

Fix `MultiProgress` alignment handling and migrate from structopt => clap #516

Closed chris-laplante closed 1 year ago

djc commented 1 year ago

Yeah, clap is at 1.64 MSRV right now. Maybe we should pin it? It's only a dev-dep for us, anyway.

chris-laplante commented 1 year ago

We could, though then we'd still have atty and maybe ansi_term :/. Right now our github actions is using 1.54. Maybe it's time to bump that up as well? (Though not necessarily all the way to 1.64)

On a side note, I may also open a PR to move off of action-rs/toolchain and onto https://github.com/dtolnay/rust-toolchain, since the former is unmaintained. A benefit is that we can use a toolchain expression like this: https://github.com/dtolnay/rust-toolchain#toolchain-expressions

djc commented 1 year ago

I'm fine bumping the MSRV to 1.56, maybe 1.58?

Moving to dtolnay/rust-toolchain sounds good, but I'd rather make MSRV bumps an explicit choice.

chris-laplante commented 1 year ago

OK I think this is ready

djc commented 1 year ago

Nice!