search

console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.22k stars 238 forks source link

impl Default for ProgressStyle? #537

Closed imbolc closed 11 months ago

imbolc commented 1 year ago

Maybe we implement Default for ProgressStyle using ProgressStyle::default_bar? It would make possible unwrap_or_default instead of ProgressStyle::with_template(...)).unwrap_or_else(|_| ProgressStyle::default_bar()).

djc commented 1 year ago

It doesn't seem like a big deal to me, and I hesitate to promote that default_bar() is "more" default than default_spinner() (although it probably is?). @chris-laplante any thoughts?

chris-laplante commented 11 months ago

It doesn't seem like a big deal to me, and I hesitate to promote that default_bar() is "more" default than default_spinner() (although it probably is?). @chris-laplante any thoughts?

I would agree - seems too opinionated to me.