search

console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.22k stars 238 forks source link

Add missing space before unit #562

Closed Error-42 closed 11 months ago

Error-42 commented 11 months ago

(I'm new to contributing, please be pedantic (but not opinionated) about the way I contribute.)

The storage unit without prefix (B, but not KB, KiB...) is not separated from the number by a space, which is incorrect (see 5.3.3 here) and inconsistent with the formatting of prefixed units (KB, KiB...) in this library.

This is a breaking change and requires the modification of one test.

chris-laplante commented 11 months ago

This seems good for consistency if nothing else. @chris-laplante, what do you think?

Makes sense to me.

chris-laplante commented 11 months ago

Thanks, @Error-42 :)