Revert heuristic algorythm

console-rs / indicatif

A command line progress reporting library for Rust

MIT License

4.21k stars 238 forks source link

Revert heuristic algorythm #620

Closed nagos closed 5 months ago

nagos commented 5 months ago

Revert ETA heuristics, untill better solution found.

Current version produce large ETA results when cycle time is greater than 15s.

This reverts commit 011c998820a5e7f2a929c18b0aa882491b05d579.

djc commented 5 months ago

I'm not interested in reverting this until we have better research showing that this is the best solution. Otherwise we're just stuck trading one person's use cases off against another's, which doesn't seem like an improvement.

afontenot commented 5 months ago

I haven't really had time to look at issues for this project, but I want to add that my PR fixed some pretty significant issues with the old approach. If for some reason the approach was found wanting, the appropriate solution would involve fixing the bugs in the previous algorithm and not just blindly reverting.