console-rs / indicatif

A command line progress reporting library for Rust
MIT License
4.45k stars 243 forks source link

Moved from unicode-width to unicode-display-width for visual grapheme width estimation #639

Closed TapGhoul closed 7 months ago

TapGhoul commented 7 months ago

This change had to be made in both crates in order to be updated correctly. The console-rs crate has been bumped an extra version as a result of a behavior change of char_width() with the unicode-display-width feature enabled - it now returns always 1 or 2, never 0 as it used to. The indicatif crate may also need to be bumped a full version as a result of the dependency change, but I'm not sure if you'd consider this a breaking change to the same degree, as it's not an advertised feature.

Related issue: https://github.com/console-rs/indicatif/issues/638 Related PR: https://github.com/console-rs/console/pull/210

TapGhoul commented 7 months ago

Pulling in @djc as requested