Class naming consistency.

consolibyte / quickbooks-php

QuickBooks Integration for PHP

Eclipse Public License 1.0

458 stars 338 forks source link

Class naming consistency. #25

Open addatwork opened 10 years ago

addatwork commented 10 years ago

Factory::create() has:

$class = 'QuickBooks_Encryption_' . ucfirst(strtolower($encrypt));
$file = '/QuickBooks/Encryption/' . ucfirst(strtolower($encrypt)) . '.php';

and the name of the class is:

class QuickBooks_Encryption_AES extends QuickBooks_Encryption

and this is not the only case.

consolibyte commented 10 years ago

Is this causing an issue for you somewhere with the auto-loader, or?

addatwork commented 10 years ago

Yeah, my app has an autoloader itself and this causes a conflict. If i test as a standalone library, it works fine.

consolibyte commented 10 years ago

OK awesome, def. agree this should be fixed. Do you have any example code I can use to duplicate this issue?

addatwork commented 10 years ago

It's a bit hard to make a code scenario, but i can offer you the names of the classes i changed:

class QuickBooks_Driver_Sql_Mysqli extends QuickBooks_Driver_Sql
class QuickBooks_Encryption_Aes extends QuickBooks_Encryption
class QuickBooks_XML_Backend_Simplexml implements QuickBooks_XML_Backend

They're not so many...