search

consolibyte / quickbooks-php

QuickBooks Integration for PHP
Eclipse Public License 1.0
458 stars 338 forks source link

Remove QuickBooks/QBXML/Schema/Object/tmp dir that is gitignored. #295

Closed amorsent closed 1 year ago

amorsent commented 3 years ago

The .gitignore file ignores tmp/ https://github.com/consolibyte/quickbooks-php/blob/master/.gitignore#L9

Yet several files under QuickBooks/QBXML/Schema/Object/tmp still exist since initial commit and have been untouched since then. https://github.com/consolibyte/quickbooks-php/commits/master/QuickBooks/QBXML/Schema/Object/tmp

It seems to me this is a mistake because these files all seem to have equivalents in QuickBooks/QBXML/Schema/Object that have been worked on since.

I assume the stuff under tmp was a pre-git snapshot of an earlier state of these files? As far as I can tell it is just junk at this point, but I could be wrong.

I discovered this after using composer to pull in consolibyte/quickbooks, then committing everything to my project's repo. When I returned to another branch on my project, these files were left hanging. They had not committed to my repo because of your gitignore.

amorsent commented 3 years ago

This pull request is still Open, and there has been no comment. Do you disagree with my assessment that these files are just old unused cruft? Thank you.

amorsent commented 2 years ago

This pull request is still Open, and there has been no comment. Do you disagree with my assessment that these files are just old unused cruft? Thank you.