consolibyte / quickbooks-php

QuickBooks Integration for PHP
Eclipse Public License 1.0
458 stars 338 forks source link

Remove Curly Braces #300

Open ServiceTo opened 3 years ago

ServiceTo commented 3 years ago

php 7.4 and php 8 have removed the ability to use curly braces to select a single character from a string.

Error is: Array and string offset access syntax with curly braces is deprecated at ....

The fix is to use square brackets. https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace

Searched for \w{ with regex and replaced all instances manually, there's two instances that aren't applicable.

My commit includes a lot of whitespace changes due to my IDE settings so easier to review by adding ?w=1 to the URL to hide the whitespace changes.