search

consolidation / annotated-command

Create Symfony Console commands from annotated command class methods.
Other
221 stars 37 forks source link

Fix isBuiltin() edge case #265

Closed greg-1-anderson closed 2 years ago

greg-1-anderson commented 2 years ago

Do not call isBuiltin() unless the reflection type is the right kind of reflection type subclass (avoid no-such-method errors).

codecov[bot] commented 2 years ago

Codecov Report

Merging #265 (a5666ad) into main (462a568) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #265      +/-   ##
============================================
- Coverage     88.90%   88.88%   -0.02%     
- Complexity      740      742       +2     
============================================
  Files            45       45              
  Lines          1875     1872       -3     
============================================
- Hits           1667     1664       -3     
  Misses          208      208
Impacted Files Coverage Δ
src/Parser/CommandInfo.php 98.44% <100.00%> (-0.02%) :arrow_down:
src/CommandFileDiscovery.php 72.17% <0.00%> (ø)
src/Parser/CommandInfoSerializer.php 100.00% <0.00%> (ø)
src/Hooks/HookManager.php 75.00% <0.00%> (+0.23%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more