Closed greg-1-anderson closed 2 years ago
Merging #280 (537a13f) into 4.x (edfcda0) will decrease coverage by
0.08%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## 4.x #280 +/- ##
============================================
- Coverage 88.57% 88.48% -0.09%
- Complexity 756 758 +2
============================================
Files 45 45
Lines 1908 1911 +3
============================================
+ Hits 1690 1691 +1
- Misses 218 220 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/Parser/CommandInfo.php | 98.85% <100.00%> (+0.01%) |
:arrow_up: |
src/Parser/DefaultsWithDescriptions.php | 92.45% <0.00%> (-3.78%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Woot!
Disposition
This pull request:
Summary
When defining cli options as ordinary method parameters, the default value is getting dropped. This means that the type and default value of the option ends up being wrong.
Description
Starting with a failing test.