consolidation / annotated-command

Create Symfony Console commands from annotated command class methods.
Other
221 stars 37 forks source link

Only call setHidden() if value is true. #299

Closed weitzman closed 1 year ago

weitzman commented 1 year ago

The problem is that hasAnnotation() is true even if the value of $hidden is false.

Disposition

This pull request:

Summary

Fixes https://github.com/drush-ops/drush/issues/5505

codecov[bot] commented 1 year ago

Codecov Report

Merging #299 (d9c36d1) into 4.x (7f5dd1a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d9c36d1 differs from pull request most recent head 3d38257. Consider uploading reports for the commit 3d38257 to get more accurate results

@@            Coverage Diff            @@
##                4.x     #299   +/-   ##
=========================================
  Coverage     88.16%   88.16%           
  Complexity      777      777           
=========================================
  Files            46       46           
  Lines          2087     2087           
=========================================
  Hits           1840     1840           
  Misses          247      247           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

greg-1-anderson commented 1 year ago

Looks good, thanks.

weitzman commented 1 year ago

I also cherry picked this to 5.x just so we dont forget it.