Allow XML output for RowsOfFields - Githubissues

consolidation / output-formatters

Apply transformations to structured data to write output in different formats.

Other

192 stars 13 forks source link

Allow XML output for RowsOfFields #60

Closed pfrenssen closed 7 years ago

pfrenssen commented 7 years ago

Currently when I try to format the output of a command using the RowsOfFields data type as XML I'm getting the following error:

Data provided to Consolidation\OutputFormatters\Formatters\XmlFormatter must be either an instance of DOMDocument or an array. Instead, an instance of Consolidation\OutputFormatters\Transformations\TableTransformation was provided.

RowsOfFields is not an array, but since it is an \ArrayObject we can derive an array from it.

Overview

This pull request:

[x] Fixes a bug
[ ] Adds a feature
[ ] Breaks backwards compatibility
[ ] Has tests that cover changes

Summary

Short overview of what changed.

Description

Any additional information.

greg-1-anderson commented 7 years ago

Yes, this is how it is supposed to work. Thanks for the fix. If you have time, a brief test of this would be appreciated.