consolidation / output-formatters

Apply transformations to structured data to write output in different formats.
Other
192 stars 13 forks source link

Remove unused __constructor() method. #93

Closed eelkeblok closed 3 years ago

eelkeblok commented 3 years ago

PHP CS is complaining about the function name "__constructor":

Method name "RowsOfFieldsWithMetadata::__constructor" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.

I presume that it was meant to be __construct(); as it stands, it appears this is not actually doing something (unless something else is also using this incorrectly named function..?)

Overview

This pull request:

Summary

Short overview of what changed.

Description

Any additional information.

codecov[bot] commented 3 years ago

Codecov Report

Merging #93 (e1cb2b6) into main (5821e6a) will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #93      +/-   ##
============================================
+ Coverage     91.31%   91.46%   +0.14%     
+ Complexity      518      517       -1     
============================================
  Files            50       50              
  Lines          1244     1242       -2     
============================================
  Hits           1136     1136              
+ Misses          108      106       -2     
Impacted Files Coverage Δ Complexity Δ
src/StructuredData/RowsOfFieldsWithMetadata.php 100.00% <ø> (+20.00%) 2.00 <0.00> (-1.00) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5821e6a...0eec24a. Read the comment docs.

greg-1-anderson commented 3 years ago

That's an odd typo. Thanks for catching it.