League container 4 - Githubissues

consolidation / robo

Modern task runner for PHP

http://robo.li

Other

2.67k stars 304 forks source link

League container 4 #1083

Closed nicosp closed 2 years ago

nicosp commented 2 years ago

Overview

This pull request:

[ ] Fixes a bug
[ ] Adds a feature
[ x] Breaks backwards compatibility
[ ] Has tests that cover changes
[ ] Adds or fixes documentation

Summary

Updates league/container to 4.x

Description

Required for compatibility with cake 4.3

greg-1-anderson commented 2 years ago

We can't bump our minimum php version without also bumping the Robo major version. I'm not sure about the timeframe for a new major version of Robo. I'm not inclined to do that soon.

This PR would be viable for Robo 3.x if it kept the same minimum php version and used "league/container": "^4.0",. We'd need a wrapper method that called either $container->addShared() or $container->share() as needed for the current version of league/container.

nicosp commented 2 years ago

Done. I added support for both versions since container 4.x is php 7.2+