PackPhar: Don't strip PHP8 attributes

consolidation / robo

Modern task runner for PHP

http://robo.li

Other

2.67k stars 304 forks source link

PackPhar: Don't strip PHP8 attributes #1084

Closed Naktibalda closed 2 years ago

Naktibalda commented 2 years ago

Overview

This pull request:

[x] Fixes a bug
[ ] Adds a feature
[ ] Breaks backwards compatibility
[x] Has tests that cover changes
[ ] Adds or fixes documentation

Summary

PackPhar::addStripped removes all comments from file, including PHP8 attributes, when used on PHP7.
This change makes addStripped keep the attributes.

greg-1-anderson commented 2 years ago

Looks good; would be fine with passing tests. Either change the CI script to set up php.ini, or perhaps use php -d ... phpunit

Naktibalda commented 2 years ago

I updated workflow script.

greg-1-anderson commented 2 years ago

Workflow not running, maybe a syntax error in config.yml?

greg-1-anderson commented 2 years ago

I updated the project settings, so hopefully your future commits will run as soon as they are pushed.

Naktibalda commented 2 years ago

CI passed

greg-1-anderson commented 2 years ago

Thanks for the fix!