search

consolidation / robo

Modern task runner for PHP
http://robo.li
Other
2.66k stars 305 forks source link

Broken symlink - breaks AWS eb deploy #679

Open et304383 opened 6 years ago

et304383 commented 6 years ago

Using the latest version (1.2.1)

$ eb deploy
WARNING: You have uncommitted changes.
Creating application version archive "app-ff34-180227_131828".
ERROR: OSError - [Errno 2] No such file or directory: '<dir>/webroot/vendor/consolidation/robo/scenarios/symfony4/tests'

The commit here seems to be the culprit:

https://github.com/consolidation/Robo/commit/32e57f86164417890b13ce5acdf0013e06e42002

Why were symlinks checked into the repo that aren't valid in the distributed package since the tests directory isn't part of the composer package that we download?

greg-1-anderson commented 6 years ago

I'm not familiar with eb deploy. If you are excluding the tests directory, perhaps you could simply exclude the scenarios directory as well?

Putting scenarios inside of tests confused phpunit.

et304383 commented 6 years ago

Well ignoring eb deploy (it's an AWS tool for packaging a repository into a zip and deploying to their managed service), the issue is still with symlinks checked into the repository that are broken.

I mean can we not agree that broken symlinks should not be part of any distribution?

I'm not excluding the tests directory. This is what's coming down from composer.

greg-1-anderson commented 6 years ago

This appears to be fixed by bd1ec91, which is in master but not yet tagged. I am inclined to exclude the entirety of the scenarios directory, as it should not be necessary for those pulling in robo via composer require et. al.

greg-1-anderson commented 6 years ago

Tagged 1.2.2; that should clear this up for you.