search

consolidation / site-alias

Manage alias records for local and remote sites.
Other
59 stars 15 forks source link

Replace Webmozart/PathUtil with Symfony/Filesystem #55

Closed ossobuffo closed 2 years ago

ossobuffo commented 2 years ago

Overview

This pull request:

Q A
Bug fix? no
New feature? no
Has tests? no
BC breaks? no
Deprecations? no

Summary

Change (hidden) dependency from webmozart/path-utils to symfony/filesystem.

Description

symfony/filesystem was already in composer.lock, but I have added it explicitly to composer.json. I am unsure whether we want to add older/newer Symfony versions the way we do with symfony/finder.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (02a7715) into main (eb0c499) will decrease coverage by 0.13%. The diff coverage is n/a.

:exclamation: Current head 02a7715 differs from pull request most recent head b689c6e. Consider uploading reports for the commit b689c6e to get more accurate results

@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
- Coverage     57.44%   57.30%   -0.14%     
+ Complexity      283      282       -1     
============================================
  Files            12       12              
  Lines           618      616       -2     
============================================
- Hits            355      353       -2     
  Misses          263      263
Impacted Files Coverage Δ
src/HostPath.php 0.00% <ø> (ø)
src/Util/FsUtils.php 0.00% <ø> (ø)
src/SiteSpecParser.php 82.50% <0.00%> (-1.23%) :arrow_down:
src/SiteAliasFileLoader.php 84.15% <0.00%> (ø)
src/SiteAliasFileDiscovery.php 87.30% <0.00%> (+0.20%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ossobuffo commented 2 years ago

composer.json says we support PHP all the way back to 5.5, but the most ancient PHP which CI tests with is 7.1. For this reason I have not included a symfony/filesystem older than 4.4 as an option in composer.json. Should we bump the minimum PHP to 7.1?

greg-1-anderson commented 2 years ago

symphony/filesystem 4.x does not have the Path class, so this will need to be reverted completely to maintain Drupal 9 compatibility. Do we want a new major branch of consolidation/site-alias to remove Webmozart/PathUtil for Drupal 10?