search

consolidation / site-alias

Manage alias records for local and remote sites.
Other
60 stars 15 forks source link

Feature/add event registration #68

Closed bomoko closed 1 year ago

bomoko commented 1 year ago

Overview

This pull request: Adds event dispatching for site aliases that are not found through the usual resolution methods

Q A
Bug fix? no
New feature? yes
Has tests? yes
BC breaks? no
Deprecations? no

Summary

Implemented the Symfony EventDispatcher component and introduced a new event

closes #66

codecov[bot] commented 1 year ago

Codecov Report

Merging #68 (1ba49cb) into main (b0eeb8c) will increase coverage by 1.02%. The diff coverage is 100.00%.

:exclamation: Current head 1ba49cb differs from pull request most recent head f8f8b30. Consider uploading reports for the commit f8f8b30 to get more accurate results

@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
+ Coverage     59.15%   60.17%   +1.02%     
- Complexity      283      290       +7     
============================================
  Files            12       13       +1     
  Lines           661      678      +17     
============================================
+ Hits            391      408      +17     
  Misses          270      270
Files Changed Coverage Δ
src/Events/AliasNotFoundEvent.php 100.00% <100.00%> (ø)
src/SiteAliasManager.php 62.31% <100.00%> (+5.65%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more