search

consolidation / site-process

A thin wrapper around the Symfony Process Component that allows applications to use the Site Alias library to specify the target for a remote call.
Other
50 stars 19 forks source link

Allow passing the file to docker-compose.yml and any other docker-compose arguments #39

Closed alexxed closed 5 years ago

alexxed commented 5 years ago

Overview

This pull request:

Q A
Bug fix? no
New feature? yes
Has tests? yes
BC breaks? no
Deprecations? no

Summary

For reference, the docker transport is launching a docker-compose command, for which the syntax is: docker compose [compose flags] exec [exec flags].

Before this PR, exec flags can be set in the drush alias file as a single string, this PR allows the same thing for docker-compose flags.

Description

An improvement here was recently merged in #37 but I need to specify the path to the docker compose yml file as well. I feel that the best approach is to not tie this to docker-compose arguments, so allow any arguments like it's done for the exec command.

greg-1-anderson commented 5 years ago

I am 👍 on docker.compose.options; however, this PR removes docker.project, which would be a backwards compatibility break. Could you maintain docker.project as an alias for docker.composer.options with -p project? It is okay if docker.project is ignored iff there is a docker.compose.options entry.

Brief docs on this behavior would be useful.

greg-1-anderson commented 5 years ago

Thanks for this enhancement.