search

consolidation / site-process

A thin wrapper around the Symfony Process Component that allows applications to use the Site Alias library to specify the target for a remote call.
Other
50 stars 19 forks source link

Use posix_isatty if it is available. #43

Closed greg-1-anderson closed 5 years ago

greg-1-anderson commented 5 years ago

Overview

This pull request:

Q A
Bug fix? yes
New feature? no
Has tests? yes/sortof
BC breaks? no
Deprecations? no

Summary

The Symfony method for detecting ttys does not seem to be as reliable as posix_isatty, so we will favor the later if it is available.

Lancelight commented 2 years ago

Whats the status of this? Forum everywhere are inundated with questions about why TTY is being set improperly by default which causes sql-dump to output to the screen via stderr I think. This results in the inability to pipe the output to a file on the local machine thats running drush via the > character. I've seen 2 issues here in the issue queue that were closed and marked as "fixed" I think rather than being marked as duplicates. This seems to be a really old issue that literally every person using drush in a remote setting will have (which is a lot).

The workaround of setting tty to 0 in an alias file works, but its a pain to have to search for fixes for basic items like this.