search

consolidation / site-process

A thin wrapper around the Symfony Process Component that allows applications to use the Site Alias library to specify the target for a remote call.
Other
50 stars 19 forks source link

Allow short options. Needed to pass along -vvv #76

Closed weitzman closed 5 months ago

weitzman commented 5 months ago

--verbose=3 is not allowed by its InputDefinition. --verbose does not accept a value (i.e. is VALUE_NONE). It must be passed as short option.

So we enable convertOptions() to pass along short options via a magic value -short. Magic values of true and false are already supported so hopefully this doesnt smell too bad.

This enables a fix for https://github.com/drush-ops/drush/pull/5948

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.91%. Comparing base (6c44638) to head (0e3927f).

:exclamation: Current head 0e3927f differs from pull request most recent head ef9350f. Consider uploading reports for the commit ef9350f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ============================================ + Coverage 77.85% 77.91% +0.05% - Complexity 174 175 +1 ============================================ Files 20 20 Lines 438 498 +60 ============================================ + Hits 341 388 +47 - Misses 97 110 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

weitzman commented 5 months ago

Test failure looks unrelated.