search

const-ae / einsum

Einstein Summation for Arrays in R
https://const-ae.github.io/einsum/
Other
9 stars 1 forks source link

\text -> \textrm #2

Closed kokitsuyuzaki closed 3 years ago

kokitsuyuzaki commented 3 years ago

I confirmed that this version could pass the following checks.

R CMD build einsum
R CMD INSTALL einsum_0.0.9001.tar.gz
R CMD check --as-cran einsum_0.0.9001.tar.gz

If there is no problem any more, could you register einsum_0.0.9001.tar.gz to CRAN? https://cran.r-project.org/submit.html

> sessionInfo()
R version 4.1.0 alpha (2021-04-26 r80229)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Debian GNU/Linux bullseye/sid

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/openblas-pthread/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/openblas-pthread/libopenblasp-r0.3.13.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

loaded via a namespace (and not attached):
[1] compiler_4.1.0
const-ae commented 3 years ago

Hi, thanks for opening a PR. I did not merge the PR because I am using roxygen to generate the .Rd files and don't edit them manually. However, I took your advice and changed \text to \textrm (https://github.com/const-ae/einsum/commit/3caa8bebaa019fe263205938e59121e203596e15 and https://github.com/const-ae/einsum/commit/5a0d78ac15b7aa7578e3e53d411dd90bf690aedd).

I am currently waiting for a last check from winbuilder, but it looks all good now, and I hope that I can submit einsum to CRAN in the next hours :)