search

const-ae / ggsignif

Easily add significance brackets to your ggplots
https://const-ae.github.io/ggsignif/
GNU General Public License v3.0
575 stars 43 forks source link

build-time dependency 'scales' is absent from DESCRIPTION #141

Closed MichaelChirico closed 1 month ago

MichaelChirico commented 1 month ago

https://github.com/const-ae/ggsignif/blob/4dcc95b59abe745e8edc420b52877a20aee31485/R/geom_signif.R#L226

IndrajeetPatil commented 1 month ago

Thanks, Michael.

I guess this hasn't been an issues because {scales} is effectively a runtime dependency of {ggsignif} via {ggplot2}. But, I agree that it's still a good idea to explicitly set it in DESCRIPTION file.

MichaelChirico commented 1 month ago

right; you never know if ggplot2 might eventually switch to (say) scales2 instead -- if you use scales:: in the package it seems correct to me it has to show up in DESCRIPTION.

unfortunately R doesn't have a system of declaring/enforcing build-time dependencies, so dropping it in Suggests is the best we can do. thanks for accepting!

const-ae commented 1 month ago

Hi Michael,

thanks for the PR. I agree that it is good practice to list all packages that are explicitly called!

Best, Constantin