search

const-ae / ggsignif

Easily add significance brackets to your ggplots
https://const-ae.github.io/ggsignif/
GNU General Public License v3.0
588 stars 43 forks source link

feature request: multiple testing correction #28

Open andreasleha opened 7 years ago

andreasleha commented 7 years ago

If I do not miss anything, there is currently no way to include a multiple comparison correction. This would be a very useful addition.

const-ae commented 7 years ago

Yes, I agree this would indeed be a useful feature. I am not quite sure what would be the best default (Bonferroni, Holm, Benjamini-Hochberg, None?), but adding the possibility for the use to choose any of those makes sense. Unfortunately I am quite busy right now, so I am not sure when I will have time to implement the feature. Of course if you would be interested in trying, I could give you some pointers where to start.

sidderb commented 7 years ago

I just submitted a pull request with this functionality quickly added - for BH/fdr only. Prior to merging you can try it out here: https://github.com/sidderb/ggsignif

jchellmuth commented 6 years ago

ggsignif works very nicely and is incredibly useful with facet_wrap. If the BH/FDR option could recognize the number of facets and correct accordingly, that would be great !

antagomir commented 6 years ago

I would also have great use for multiple testing option-

iferres commented 2 years ago

+1 for this feature. Thanks for the package, btw!

TahelRonel commented 1 year ago

Was this feature added? If so, where do I find how to use it? Otherwise, is there another way to use e.g. pairwise.wilcox.test as the test? Many thanks.

elnaggarj commented 1 year ago

I've incorporated sidderb FDR functionality to the newest version of ggsignif. Please find at ggsignif-FDR