search

const-ae / glmGamPoi

Fit Gamma-Poisson Generalized Linear Models Reliably
105 stars 14 forks source link

Fix partial matches #4

Closed jeffreypullin closed 4 years ago

jeffreypullin commented 4 years ago

Found with options(warnPartialMatchDollar = TRUE)

const-ae commented 4 years ago

Thank you for the PR. I should probably enable options(warnPartialMatchDollar = TRUE) myself at some point :) I will wait for the checks to complete (usually takes half an hour), before I merge. But looking at the code, it looks very good :)

jeffreypullin commented 4 years ago

Sounds good! I have the following in my .Rprofile:

options(warnPartialMatchAttr = TRUE, 
        warnPartialMatchDollar = TRUE,
        warnPartialMatchArgs = TRUE)

taken from Kevin Ushey's .Rprofile :)

codecov-commenter commented 4 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          21       21           
  Lines        1338     1338           
=======================================
  Hits         1238     1238           
  Misses        100      100
Impacted Files Coverage Δ
R/glm_gp_impl.R 93.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e196029...de2d3b8. Read the comment docs.

const-ae commented 4 years ago

I have merged the PR. The failure on Ubuntu with 3_10 is a false positive. Again, thank you for the submitting :)