Add codecov.io - Githubissues

constabulary / gb

gb, the project based build tool for Go

https://getgb.io/

MIT License

2.15k stars 150 forks source link

Add codecov.io #664

Closed gliptak closed 7 years ago

gliptak commented 7 years ago

You will likely have to login and enable the project at https://codecov.io/

Here is the report generated for my branch:

https://codecov.io/gh/gliptak/gb/branch/codecov1

codecov-io commented 7 years ago

Current coverage is 55.51% (diff: 100%)

No coverage report found for master at 06cc925.

Powered by Codecov. Last update 06cc925...01140f6

gliptak commented 7 years ago

Would you like see additional changes? Thanks

davecheney commented 7 years ago

I probably won't have time to review this til the weekend.

On Thu, Nov 24, 2016 at 2:09 AM, Gábor Lipták notifications@github.com wrote:

Would you like see additional changes? Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/constabulary/gb/pull/664#issuecomment-262540214, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA-PQlcrVoeGlI9wuZrOQl2_93dZIks5rBFcmgaJpZM4K3rj6 .

davecheney commented 7 years ago

I had a quick look at this and it looks like there are some files missing

0.16s$ bash <(curl -s https://codecov.io/bash)
  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-31d77b9
==> Travis CI detected.
    project root: .
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Searching for coverage reports in:
    + .
==> Python coveragepy not found
--> No coverage report found.
    Please visit http://docs.codecov.io/docs/supported-languages

gliptak commented 7 years ago

@davecheney I'm not sure what to make of those generic messages above. If you look at the bottom of

https://codecov.io/gh/constabulary/gb/pull/664?src=pr

you will see listing of the covered files. I can submit a folloup PR to fine-tune.

davecheney commented 7 years ago

I'm not convinced this is working, but there's no point in arguing about it in a PR.

davecheney commented 7 years ago

@gliptak can you please take a look, I don't think this is working.

gliptak commented 7 years ago

@davecheney You are correct, it is not working.

My PR replaced go test with coverage.sh:

https://github.com/constabulary/gb/pull/664/commits/01140f64846f2ad184e12f8a2bb4ba33d0a52af1#diff-354f30a63fb0907d4ad57269548329e3R28