search

constabulary / gb

gb, the project based build tool for Go
https://getgb.io/
MIT License
2.15k stars 150 forks source link

Remove filepath.Rel code from gc helper. #693

Closed davecheney closed 7 years ago

davecheney commented 7 years ago

GoFiles in gb come in two kinds.

  1. relative to pkg.Dir
  2. absolute

In this case the work to absify then relify the path is a noop, which is further proven by removing it.

codecov-io commented 7 years ago

Codecov Report

Merging #693 into master will decrease coverage by -0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   53.39%   53.32%   -0.08%     
==========================================
  Files          40       40              
  Lines        3045     3036       -9     
==========================================
- Hits         1626     1619       -7     
+ Misses       1242     1241       -1     
+ Partials      177      176       -1
Impacted Files Coverage Δ
build.go 80.13% <ø> (+0.13%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d94d4f1...d21a06d. Read the comment docs.