search

constabulary / gb

gb, the project based build tool for Go
https://getgb.io/
MIT License
2.15k stars 150 forks source link

Add semaphore to `gb vendor restore` #695

Closed andremedeiros closed 7 years ago

andremedeiros commented 7 years ago

For projects with a lot of dependencies, gb vendor restore won't work all the time and fail silently.

This makes pulling them more manageable and more resilient.

Closes #698

dcheney-atlassian commented 7 years ago

Thanks for fixing this. This makes me kind of mad actually. gb vendor restore used to work perfectly, slowly, reliably, perfectly. Then we had to go and make it faster, and now it is less reliable. I am unconvinced that this was an improvement.

I'm tempted to revert the original parallisation change.

dcheney-atlassian commented 7 years ago

Oh, and you must raise a bug before proposing a PR. Thank you.

andremedeiros commented 7 years ago

I'm tempted to revert the original parallisation change.

This is still good to have. The problem I was facing was that I worked on a project with over 100 dependencies and it gets hairy for those cases.

I'll also raise a bug.

jeromer commented 7 years ago

Do you plan to include this patch ? It would be super useful.