search

constabulary / gb

gb, the project based build tool for Go
https://getgb.io/
MIT License
2.15k stars 148 forks source link

gb support for plugins in Go 1.8 #700

Closed bstarynk closed 6 years ago

bstarynk commented 7 years ago

Go 1.8 has plugins and a plugin package. With the go command, plugins can (and should) be compiled with go build -buildmode=plugin ; what is the equivalent with gb ? (it should be documented)

Thanks

Basile Starynkevitch

davecheney commented 7 years ago

Sorry, gb doesn't support any of the go build modes. It's not on my roadmap to add them.

On Sun, 19 Mar 2017, 17:46 Basile Starynkevitch notifications@github.com wrote:

Go 1.8 has plugins https://golang.org/doc/go1.8#plugin and a plugin https://golang.org/pkg/plugin/ package. With the go command, plugins can (and should) be compiled with go build -buildmode=plugin ; what is the equivalent with gb ? (it should be documented)

Thanks

Basile Starynkevitch http://starynkevitch.net/Basile/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/constabulary/gb/issues/700, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA5sXPgdiz90XYoHAXTeQeoW1IXhQks5rnM9PgaJpZM4MhppL .

bstarynk commented 7 years ago

It is not a matter of supporting go build modes. It is a matter of supporting plugins (which is a new and important feature of Go 1.8 language). Building a plugin should be possible with gb, as soon as gb claims to support the full Go language (its 1.8 version). Or you should document that plugins is a feature of the Go language that gb don't support. Then people (lilke me) who need plugins won't use gb; I have chosen to code in Go only once it had plugins.

davecheney commented 7 years ago

Real talk: plugins are pretty broken in 1.8, I'm not planning on looking at it til after 1.9

On 19 Mar 2017, at 20:36, Basile Starynkevitch notifications@github.com wrote:

It is not a matter of supporting go build modes. It is a matter of supporting plugins (which is a new and important feature of Go 1.8 language).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

we-zhang commented 6 years ago

+1 for supporting go plugin in gb

davecheney commented 6 years ago

Being straight with you, plug-ins in go are pretty broken and only work on Linux, sorta.

I don’t have any plans to add support for them to gb.

On 17 Nov 2017, at 03:25, WeZhang notifications@github.com wrote:

+1 for supporting go plugin in gb

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

davecheney commented 6 years ago

Won’t fix. Sorry.

bstarynk commented 6 years ago

On 11/25/2017 04:08 AM, Dave Cheney wrote:

Won’t fix. Sorry.

Then you need to document that. This would avoid future people coding in Go and using plugins to even consider using GB.

You need to mention lack of plugin support in your README.md and on the https://getgb.io/ site.

Cheers.

-- Basile STARYNKEVITCH == http://starynkevitch.net/Basile opinions are mine only - les opinions sont seulement miennes Bourg La Reine, France