Add CXXFiles to TestPackage

[lukejohnston]

With a project layout like this:

.
└── src
    └── proj
        ├── a
        │   ├── a.cpp
        │   ├── a.go
        │   └── a.h
        └── main.go

the test command will give a linker error when processing the a directory. This is because the .cpp files are not added to the test package. This change adds the .cpp files to the test package.

[davecheney]

Thank you. Can you please add a test to cmd/gb/gb_test.go

On Tue, May 9, 2017 at 4:48 AM, Luke Johnston notifications@github.com wrote:

With a project layout like this:

. └── src └── proj ├── a │ ├── a.cpp │ ├── a.go │ └── a.h └── main.go

the test command will give a linker error when processing the a directory. This is because the .cpp files are not added to the test package. This change adds the .cpp files to the test package.

You can view, comment on, or merge this pull request online at:

https://github.com/constabulary/gb/pull/716 Commit Summary

• Add CXXFiles to TestPackage

File Changes

• M test/test.go https://github.com/constabulary/gb/pull/716/files#diff-0 (1)

Patch Links:

• https://github.com/constabulary/gb/pull/716.patch
• https://github.com/constabulary/gb/pull/716.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/constabulary/gb/pull/716, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA9QIaD5Kro6YyWsje4CmLMg_lknwks5r32ObgaJpZM4NUWCE .

[codecov-io]

Codecov Report

Merging #716 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   52.83%   52.85%   +0.01%     
==========================================
  Files          42       42              
  Lines        3155     3156       +1     
==========================================
+ Hits         1667     1668       +1     
  Misses       1344     1344              
  Partials      144      144

Impacted Files	Coverage Δ
test/test.go	72.48% <100%> (+0.18%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ab23c1...ec09189. Read the comment docs.

[lukejohnston]

Sure, done. Thanks for the quick reply.

[davecheney]

LGTM. Thanks.