search

constantcontact / jenkins_pipeline_builder

YAML/JSON driven jenkins job generator that lets you version your artifact pipelines alongside with the artifact source itself.
MIT License
62 stars 43 forks source link

CD-3136 Adding support for rvm0.6 wrapper extension #133

Closed kmcarol26 closed 6 years ago

kmcarol26 commented 6 years ago
crimsonknave commented 6 years ago

From what I can tell the xml generated for version 0.6 is the same as for version 0.5. The version logic in extension_set.rb should mean that you only need to declare a new version if the xml is different.

https://github.com/constantcontact/jenkins_pipeline_builder/blob/master/lib/jenkins_pipeline_builder/extension_set.rb#L163-L167

kmcarol26 commented 6 years ago

Closing PR in light of above comment.