search

constantcontact / ruby-sdk

Constant Contact Ruby SDK for v2 API
Other
17 stars 47 forks source link

extend api for /emailmarketing/campaigns/:campaignId/preview #46

Closed dustinsgoodman closed 7 years ago

dustinsgoodman commented 9 years ago

This PR does a couple things. The main thing is it adds support for the aforementioned endpoint to match the current Constant Contact API spec. Secondly, it remove the absurdly high version requirement for the mime type gem. The latter was to help support Ruby 4.0+ which version 2.0.1 currently does not due to the mime type requirement. I added specs for the new endpoints and upped the subversion of the gem to meet the new standards.

dustinsgoodman commented 9 years ago

So there are actually a few bugs in this new endpoint that I would love some advice on. The email preview endpoint doesn't return with the same key names as the campaign endpoint so the mapping to the campaign object does not work. On top of that, it doesn't return the entire email_content value. It would be great if this endpoint existed though.

dustinsgoodman commented 9 years ago

I just pushed an update that should resolve the previously mentioned bugs.

csciuto commented 9 years ago

Thanks for the contribution! I made a couple of comments at the line level.

csciuto commented 9 years ago

Let's associate this with an issue: https://github.com/constantcontact/ruby-sdk/issues/50

dustinsgoodman commented 7 years ago

I never got back to this and you guys have already fixed it via #51. Closing.