relax and change dependencies to be compatible with rails 5

[derekyau]

Hi,

We recently had to use constant contact with Rails5 and were running to some compatibility problems. As such, I've changed some of the dependency versions in the gemspec and re-ran all the specs.

Everything seems to be passing - and we are successfully using the gem in the project now. I was hoping you could take a quick look and ensure this is alright? If so perhaps we could merge it?

Thanks

[derekyau]

the constant contact guys will have to merge this

Derek Yau

On Monday, September 5, 2016 at 11:34 AM, medBouzid wrote:

Yes I have the same issue in Rails 5 can you please merge this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/constantcontact/ruby-sdk/pull/60#issuecomment-244796902), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAbj60OId6KfaDAUcmvEpyD22ozVZD2Hks5qnGCbgaJpZM4Jjf9q).

[csciuto]

Hi Derek - thanks for the Pull Request! Could you please expand a bit on the compatibility issues you were seeing? I created a new Rails 5 project, added constantcontact as a dependency, and ran bundle install and of course hit issues due to the locked mime-types = 3.1 dependency for Rails 5.

Bundler could not find compatible versions for gem "mime-types":
  In snapshot (Gemfile.lock):
    mime-types (= 3.1)

  In Gemfile:
    constantcontact (~> 2.2.1) was resolved to 2.2.1, which depends on
      mime-types (>= 2.4.1, ~> 2.4)

    rails (>= 5.0.0.1, ~> 5.0.0) was resolved to 5.0.0.1, which depends on
      actionmailer (= 5.0.0.1) was resolved to 5.0.0.1, which depends on
        mail (>= 2.5.4, ~> 2.5) was resolved to 2.6.4, which depends on
          mime-types (< 4, >= 1.16)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

However, if I run bundle update, it will resolve this as it says.

Still, there is another PR out (https://github.com/constantcontact/ruby-sdk/pull/46) that removes the mime-types dependency entirely. It does appear that it doesn't get used.

If I remove the dependency on mime-types, even without your changes to rest-client, bundle install works fine on both a new Rails 4 and Rails 5 project.

That said, I didn't stand a complex app up exercise functionality beyond the unit tests.

Thoughts?

[scratchoo]

any news about this ? I cannot move ahead because of that error, please help!!!!!!

[gregblass]

Hey there! About to dive into using this gem in a Rails 5 project. Just wondering what the status of this is? Is there anything holding this back?

[csciuto]

Hi @gregblass - I think that you should be all set. My notes from September 2016 discuss removing a bad gem dependency that was preventing Rails 5 support, but I hadn't done extensive testing. I did in fact merge in those changes with version 4.0.0 of the gem, so as long as you're at that level (I would go as current as possible), you should be ok.

I've left this pull request open waiting to hear if people are still having Rails 5 issues or not due to the gem, so please let me know how things look and we can either update or close this.