search

constantin-p / cp-react-tree-table

A fast, efficient tree table component for ReactJS.
https://constantin.software/cp-react-tree-table
MIT License
94 stars 27 forks source link

Issue with scrollIntoView #6

Closed felipefaraco closed 5 years ago

felipefaraco commented 6 years ago

Hi,

I found an issue with your demo (https://jsfiddle.net/constantin_p/fvuswrbm/), reproduced both on Chrome and FF. Steps:

1 Un-toggle both depth:2 and depth:1 2 Scroll up to the top of the list 3 Click the button "Scroll to ..." 4 Notice how it only scrolls to depth:2 (it does expand depth:3, but won't scroll to that position)

constantin-p commented 6 years ago

Hi @felipefaraco,

Thanks for your bug report. I can reproduce the issue and I'm gonna push a fix later this week.

constantin-p commented 5 years ago

v0.5.1 (commit b81251a56f89df5ab150cba0980e4d9e4b63ac43) should contain the fix for the described issue. @felipefaraco let me know if everything works on your end.

Edit: The demo has been updated to the latest version (you can use the JSFiddle link to test the functionality)

felipefaraco commented 5 years ago

Just tested, works great! Thank you for doing this, I really like your library, suits my data very well! 👍