constelation / monorepo

Mono repo for constelation's Components, functions, and CONSTANTS
https://constelation.github.io/monorepo/
MIT License
12 stars 3 forks source link

required onPress / default opacity on Event_ #85

Open heaversm opened 7 years ago

heaversm commented 7 years ago

Event_ requires an onPress prop in order to carry out the specified pressEffect. E.g.:

<Event pressEffect='opacity' onPress={null}>

Suggest either having this as a default prop, or removing the requirement to pass this prop altogether, as it is common to want to display this feedback on a clickable item but not necessarily have it carry out a function.

Also, activeOpacity seems to pretty commonly be .8 in our apps, perhaps we set this as the default? Looks like maybe the current default is .2(?) (src/index.native.tsx)