Display Direction indicators doesn't appear to be working on graphs

GammaVel commented 3 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Running the latest version of Constellation
- Attached the Support Package via Help > Support Package
- Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
- Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
- Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

Display Direction Indicators is one of the options available under the main menu Display Option. I've tried this out on a few graphs and the functionality doesn't appear to be working. If it is turned off or on it doesn't seem to make a difference to the display on the graph.

Steps to Reproduce

Open a graph in Constellation > Go to Main menu > Display > Direction Indicators
Check the graph > I can still see the direction indicators on the transactions
Try zooming in then changing to edges, links to see if that makes a difference
Look at the help guide for more details > unable to find any info on what this does

Expected behaviour: The arrow indicators move? or are not shown.

Actual behaviour: Turning this on and off doesn't impact the graph.

Reproduces how often: 100%

Additional Information

NA

sol695510 commented 3 years ago

From looking at the associated files from the search I'm not too sure what exactly they do either, but the changelog comment seems to suggest it was disabled in some capacity.

This is a portion of GraphRenderable where it is used in some way. @algol60 is one of the authors so they may have some insight into this @GammaVel.

arcturus2 commented 3 years ago

Thanks @sol695510 for looking into it. Your looking at the right parts!

After the last time the graph renderer was re-written this animation stopped working without graph input. This is by no means acceptable but how it works is you have to do something to the graph to trigger the animation and what I'm doing is dragging the graph around with my right click. Can you see the animation?

showing direction

It needs to be fixed but is a low priority.

sol695510 commented 3 years ago

As with what as written in the change log, the direction indicators do work as intended, but the effect is just very subtle. Observe the transaction after I turn the option on and pan the graph, there is an animation like an "electric current" running in the direction the transaction's arrow is pointed in.