Can't press enter on the Edit dialog box for editing a Float value - Githubissues

constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.

https://constellation-app.com

Apache License 2.0

386 stars 59 forks source link

Can't press enter on the Edit dialog box for editing a Float value #1347

Open CrucisGamma opened 3 years ago

CrucisGamma commented 3 years ago

Would like to be able to press enter after editing a value and have it apply (pressing esc does make it go away) instead of having to click "Ok"

CrucisGamma commented 2 years ago

Also, would like to be able to press 'Enter' to have it click 'OK' when adding in a new field (currently have to take my hands off the keyboard onto the mouse, navigate the cursor to the OK button and then click it and then navigate the cursor back to the '+' button to click it again. There's around 24 columns that have been found from the json file I'm ingesting in this example. It's not a quick process :( I can navigate to the OK button via shift and tab which is quicker than otherwise using the mouse

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

capricornunicorn123 commented 3 months ago

Some Extra context to this ticket.

As discussed today, if the goal of this ticket is to reduce the need for users to have to use the mouse to navigate to the ok button, why not ensure that users can iterate over all inputs and buttons using the tab key. Being able to navigate iteratively within a view or dialog without a mouse would make the application far more accessible to users who are unable to use a mouse easily (laptop users, vision impaired users).

Currently there are some dialogs that enable this functionality and others that do not.

When adding a new attribute in the attribute editor we are presented with this dialog: This dialog enables users to access all inputs and buttons (when the inputs have valid data) by pressing the tab key.

When adding a new attribute in the ImportFromFile view we are presented with this dialog: This dialog has the potential to enable users to access all inputs and buttons by pressing the tab key however the description field accepts tab as a valid input so blocks the progression to the next input. (Press shift tab to iterate over the fields / buttons in reverse to see that it is possible untill the description text area is reached.

If this tab key solution is decided to satisfy the needs of users without adding the complex logic for when an enter means "new line" and when an enter means "click the OK button", then there will be number of other Dialogs that will need to be reviewed: Primarily the 'PluginParametersSwingDialog' and the Data Access View.

This ticket could addressed in isolation or be included in an accessibility review to test similar functionality in all views and windows.

capricornunicorn123 commented 3 months ago

Also worth noting that this tab functionality has been enabled on ConstellationInputField's where pressing tab will always result in focus traversal and not indentation. See PR #2025