Multiple identical strings across java files

CrucisGamma commented 2 years ago

There's lots of the same hardcoded identical strings across lots of files. On my (admittedly incomplete) analysis, these are the single line strings between 4-70 characters that occur across multiple files.

For example, the string "Selected Only" (exact case) exists 24 separate times across all files as analysed 20211019.

It may be a big job to refactor code get a "StringConstants.java" file that is referenced by different modules within Constellation but possibly nice to do.

57 | ANALYTIC
30 | LOW LEVEL
24 | Selected Only
22 | Menu/Arrange
21 | Selection
20 | Menu/Selection
20 | selected
19 | explorer
18 | Menu/Views
16 | Display
16 | Finished
15 | Include Undirected
15 | Treat undirected connections as bidirectional connections
15 | treat_undirected_bidirectional
15 | user.home
14 | Not supported.
13 | Include Incoming
13 | Include Outgoing
13 | Include incoming connections
13 | Include outgoing connections
13 | Normalise By Max Available Score
13 | Normalise calculated scores by the maximum calculated score
13 | include_connections_in
13 | include_connections_out
13 | normalise_available
13 | selected_only
12 | Classpath
12 | Thread was interrupted
12 | for the element type associated with this analytic question.
11 | Menu/Experimental/Arrangements
11 | WELCOME
11 | description
11 | smallInfoText
10 | Calculate using only selected elements
10 | Menu/Tools
10 | constellation
10 | ignoring parameter change type {0}.
10 | mvMatrix
10 | pMatrix
10 | transaction
10 | visibilityHigh
10 | visibilityLow
9 | -fx-background-color: transparent;
9 | -fx-font-size:%d;
9 | Loaders/application/x-graph/Actions
9 | Loaders/application/x-nebula/Actions
9 | Similarity
9 | Toolbars/Arrange
9 | Toolbars/Selection
9 | deprecation
8 | Description
8 | Graph id
8 | Menu/File
8 | Menu/Help
8 | No graph with id
8 | TimelineTopComponent
8 | attribute
8 | au.gov.asd.tac.constellation.utilities
8 | destination
8 | divider-location
8 | extentLabel
8 | graph_id
8 | greyscale
8 | time_zone
8 | timeline_state
7 | %s - %s
7 | -fx-border-color: transparent;-fx-background-color: transparent;
7 | -fx-font-weight: bold;
7 | Centrality
7 | Element Type
7 | Error converting String '%s' to short
7 | Menu/Display
7 | Metrics
7 | No Value
7 | Unexpected class %s
7 | boolean
7 | elementType
7 | fragColor
7 | morphMix
7 | xyzTexture
6 | 'Color Elements' is not supported
6 | Arranging...
6 | Identifier
6 | Menu/Display/Dimming
6 | Menu/Display/Reset View by Axis
6 | Menu/File/Export
6 | Minimum Common Features
6 | New Graph
6 | Selected Only Mode
6 | Toolbars/Display
6 | Toolbars/Views
6 | What's New
6 | columns
6 | minimum_common_features
6 | mvpMatrix
6 | unknown
6 | yyyy-MM-dd
5 | DateFormat
5 | Directed
5 | Editing...
5 | Filter:
5 | JDBC Import
5 | Location
5 | Menu/Display/Element Visibility
5 | Menu/Edit
5 | Menu/Tools/Cluster
5 | Normalise By Max Possible Score
5 | Normalise calculated scores by the maximum possible score
5 | Not supported yet.
5 | Transaction
5 | UTILITY
5 | Unknown
5 | Utility class
5 | Vertex Id
5 | You should only select one method of normalisation
5 | [%s: %d]
5 | __func(__p1)
5 | attributes
5 | destination.
5 | directed
5 | fallthrough
5 | filename
5 | hiddenSplitter
5 | highlightColor
5 | is_empty
5 | normalise_possible
5 | parameters
5 | source.
5 | transaction.
4 | Count:
4 | #CTL_TimelineAction
4 | %s %s %s
4 | 'Size Elements' is not supported
4 | , Size:
4 | ,transition=
4 | -fx-background-color: #DDDDDD;
4 | -fx-text-fill: white;
4 | .nebula
4 | <No Value>
4 | Arrow
4 | Attribute
4 | Attributes
4 | CTL_TimelineAction=Timeline
4 | CTL_TimelineTopComponent=Timeline
4 | Concept class
4 | Content
4 | Continue
4 | Data Access View cannot be created.
4 | DateFormat=d MMM yyyy  HH:mm
4 | DateTimeLabel=Temporal Attribute:
4 | DimNodesLabel=Dim Excluded Nodes
4 | Display help for Timeline
4 | Epsilon
4 | Error refreshing scatter plot:
4 | EventLabel
4 | EventLabel=events
4 | Expected attribute not found on graph:
4 | Failed to load data access plugins.
4 | HideNodesLabel=Hide Excluded Nodes
4 | Incomplete
4 | Index:
4 | Initialising dimming or hiding from timeline.
4 | Iterations
4 | Lbl_ShowSelectedOnly=Show selected only
4 | MSG_SelectColor
4 | Menu/Experimental/Tools
4 | Menu/Experimental/Views
4 | No schema available
4 | NoAttributes=<No Valid Attributes>
4 | NoGraph=<No Active Graph>
4 | NoTemporal=<No Temporal Data Present On Current Graph>
4 | NodeLabelsCaption=Labels
4 | Overridden Type
4 | Quick Find was interrupted
4 | Read mode is not supported by this plugin
4 | Replace
4 | Select Date
4 | SelectLabelAttribute=<Select Label Attr>
4 | ShowLabels=Show Node Labels
4 | ShowNodesLabel=Show Excluded Nodes
4 | String does not represent a graph label:
4 | Super Type
4 | The change threshold at which equilibrium can be considered reached
4 | The current state of the timeline with relation to this graph
4 | The graph element type
4 | The number of iterations to run before returning a result
4 | Timeline
4 | Timeline: Initialise Dimming or Hiding
4 | Timeline: Update Dimming or Hiding
4 | TimelineSelectionPlugin=Timeline: Update Selection
4 | TimelineStatePlugin=Timeline: Update State
4 | Toolbars/File
4 | Undirected
4 | Update Timeline from Graph
4 | Vertex Ids
4 | Waiting...
4 | Working...
4 | ZoomtoSelection=Zoom to Selection
4 | au.gov.asd.tac.constellation.views.timeline.TimelineTopComponent
4 | au/gov/asd/tac/constellation/views/timeline/resources/timeline.png
4 | constellation/Preferences
4 | datetime_attribute
4 | default
4 | definitions
4 | drawHitTest
4 | element_type
4 | epsilon
4 | exclusion_state
4 | forward
4 | graphId
4 | has_node_label_attributes
4 | integer
4 | is_node_label_on
4 | iterations
4 | lower_time_extent
4 | named_selection
4 | node_label_attribute
4 | resources/Style-Container-Dark.css
4 | resources/Style-Container-Light.css
4 | resources/Style-Overview-Dark.css
4 | resources/Style-Overview-Light.css
4 | resources/Style-Timeline-Dark.css
4 | resources/Style-Timeline-Light.css
4 | selectedOnly
4 | shaders/PassThru.fs
4 | shaders/PassThru.vs
4 | show_selected_only
4 | source < dest is always uphill
4 | source > dest is always downhill
4 | super_type
4 | timeline-hs.xml
4 | transparent
4 | tx_dir_
4 | upper_time_extent
3 | nodes.
3 | # {0} - file name
3 | # {0} - graph
3 | # {1} - name
3 | #%02x%02x%02x
3 | %s (%s)
3 | %s%s.CONSTELLATION%sJDBCImport%s
3 | ,modificationCounter=
3 | 127.0.0.1
3 | <Multiple Values>
3 | >%s</span>
3 | Analytic View: Color Elements
3 | Apply normalisation separately for each connected component
3 | CTL_TimelineAction
3 | CTL_TimelineTopComponent
3 | ColorElementsPlugin.reset
3 | Complete with Schema
3 | Connection
3 | ConnectionMode
3 | Connections
3 | Contains
3 | Could not create drop down arrow image
3 | Created
3 | Custom Format
3 | DateTime
3 | DateTimeLabel
3 | Description:
3 | DimNodesLabel
3 | Dimensions
3 | Entered value is not a date of format yyyy-mm-dd.
3 | GENERAL
3 | HINT_TimelineTopComponent
3 | HideNodesLabel
3 | Invalid expression size:
3 | Lbl_ShowSelectedOnly
3 | Magenta
3 | Menu/Display/Connection Types
3 | Network
3 | No IO provider found for attribute type:
3 | NoAttributes
3 | NoGraph
3 | NoTemporal
3 | NodeLabelsCaption
3 | Normalise Connected Components
3 | Options
3 | Password
3 | Query Error
3 | Querying...
3 | Remember Open/Save Location
3 | Select All
3 | SelectLabelAttribute
3 | ShowLabels
3 | ShowNodesLabel
3 | Starts with
3 | TableViewTopComponent
3 | Threshold
3 | Time spinners must have numeric values
3 | TimelineSelectionPlugin
3 | TimelineStatePlugin
3 | Transaction Types
3 | ZoomtoSelection
3 | [a-z]{1}.*
3 | application/x-graph
3 | attributeName
3 | au.gov.asd.tac.constellation.views.mapview
3 | au/gov/asd/tac/constellation/graph/file/nebula/resources/nebula.png
3 | background_icon
3 | community
3 | invalid
3 | line_style
3 | localhost
3 | mod_count
3 | modules/ext/icons/drop_down_arrow.png
3 | normalise_connected_components
3 | nradius
3 | org/netbeans/core/output2
3 | os.name
3 | password
3 | plugin_name
3 | plugins
3 | recordstore
3 | threshold
3 | top_level_type
3 | user.name
3 | version
3 | vertex_id
3 | visibility
3 | visual_state
3 | vx_dst_
3 | vx_src_
3 | yyyy-MM-dd HH:mm:ss
3 | yyyy-MM-dd HH:mm:ss z
3 | {%s;%s;%s}
2 | <= x <
2 | == similarity ==
2 | Attribute(s) Selected
2 | Parameters
2 | created an exception
2 | was interrupted
2 | #CTL_TutorialTopComponentAction
2 | #CTL_Uncollide2DAction
2 | #LBL_Graph_LOADER
2 | #LBL_Nebula_LOADER
2 | %4d-%02d-%02d
2 | %f,%f,%f,%f
2 | %s (%d)
2 | %s <strong>%s</strong> <span class=\
2 | %s Information
2 | %s at %s
2 | %s error opening graph:%n%s
2 | %s is not a valid element type
2 | %s read complete (%.1fs)
2 | %s script file
2 | %s: %s\n
2 | %s\t%d\n
2 | '%s' already exists. Do you want to overwrite it?
2 | 'Hide Elements' is not supported
2 | (?:\\/\\/
2 | (Built-in)
2 | ): \n\n\t
2 | * To filter Attributes, start typing in the Attributes Filter.
2 | , \n\n\t
2 | #NAME?
2 | #NAME?
2 | -fx-background-color: rgb(180,64,64); -fx-padding: 2 5 2 5;
2 | -fx-background-color: rgb(64,180,64); -fx-padding: 2 5 2 5;
2 | -fx-background-color:#444444;
2 | -fx-fill: white; -fx-font-smoothing-type:lcd;
2 | -fx-font-size: 11pt;
2 | -fx-label-padding:
2 | -fx-padding: 5px;
2 | -fx-text-fill: #cccccc;
2 | -fx-text-fill: grey;
2 | .source
2 | <string>
2 | <unknown>
2 | A description must be supplied
2 | A marker must have one or more locations.
2 | A name must be supplied
2 | A set of vertex ids to gather
2 | Add Connection
2 | Add Custom Blazes
2 | Add Driver
2 | Add Label
2 | Advanced Find
2 | All Files
2 | Ambiguous operator
2 | An attribute with that name already exists.
2 | An error occured reading file %s
2 | Analytic View: Size Elements
2 | Analytic View: Update State
2 | AnalyticViewTopComponent
2 | Arrange
2 | Arranging
2 | Attempting to write on the EDT
2 | Attribute name:
2 | AttributeEditorTopComponent
2 | Autosave
2 | Background Icon
2 | Background.Flat Square
2 | Background.Round Circle
2 | Background.Sphere
2 | Bad value: force %f %f isNan(force)
2 | Bad value: isNaN(force)
2 | Bin Into Buckets
2 | Bin Into Logarithmic Buckets
2 | Bounding box is empty.
2 | Bucket Size
2 | CTL_DrawBlazesAction
2 | CTL_DrawConnectionLabelsAction
2 | CTL_DrawConnectionsAction
2 | CTL_DrawEdgesAction
2 | CTL_DrawLinksAction
2 | CTL_DrawNodeLabelsAction
2 | CTL_DrawNodesAction
2 | CTL_DrawTransactionsAction
2 | CTL_StartFileListenerAction
2 | CTL_StopFileListenerAction
2 | CTL_ToggleGraphVisibilityAction
2 | CTL_Uncollide2DAction
2 | CTL_Uncollide2DAction=Uncollide
2 | CTL_VisualGraphTopComponent
2 | Calculate analytic only on the subgraph of transactions of these types
2 | Calculating
2 | Can't buffer data before initialising the batch
2 | Can't create directory '%s'.
2 | Can't create template directory '%s'.
2 | Can't find schema factory '%s'
2 | Can't save import definition: %s
2 | Cannot set GraphAttributeParameterValue using a String
2 | Category
2 | Choose a color
2 | Clear Default
2 | Cluster.ChineseWhispers
2 | Cluster.ChineseWhispers.Colour
2 | Cluster.Hierarchical
2 | Cluster.Hierarchical.Colour
2 | Cluster.Infomap
2 | Cluster.Infomap.Colour
2 | Cluster.KTruss.Colour
2 | Cluster.KTruss.Highest
2 | Cluster.Named
2 | ClusteringCoefficient
2 | Comment
2 | Completed successfully
2 | Completing schema...
2 | Connecting to url {0}
2 | Connection Labels
2 | Connection String
2 | Content which has been translated to English
2 | Content-Type
2 | Content.Application
2 | Content.Author
2 | Content.CharacterCount
2 | Content.Company
2 | Content.Description
2 | Content.FileExtension
2 | Content.FileName
2 | Content.FileType
2 | Content.LastAuthor
2 | Content.LineCount
2 | Content.PageCount
2 | Content.Permission
2 | Content.Size
2 | Content.Subject
2 | Content.Template
2 | Content.Title
2 | Content.Translated
2 | Content.URL
2 | Content.Vendor
2 | Content.Version
2 | ConversationViewTopComponent
2 | Could not find columns object containing column names
2 | Could not find data object containing data rows
2 | Could not make texture context current.
2 | Couldn't find file %s at %s in module %s
2 | Current attributes:
2 | DEFAULT
2 | Data Access View
2 | DataAccessViewTopComponent
2 | Datetime
2 | Day of Week
2 | Deactivate all plugins
2 | Default
2 | Default Value
2 | Definitions
2 | Delete Note
2 | Delimited File Import
2 | Delimited Importer
2 | DelimitedImportTopComponent
2 | Deselect Blazes
2 | Destination
2 | Destination:
2 | Display help for %s
2 | Distance
2 | Document
2 | Draw Flag
2 | Duplicate Key has been found. Merging duplicate nodes
2 | Duplicate Primary Keys (
2 | Element type must be VERTEX or TRANSACTION
2 | Enabled
2 | EndTime
2 | Entered value is not a byte.
2 | Entered value is not a double.
2 | Entered value is not a float.
2 | Entered value is not a long.
2 | Entered value is not a short.
2 | Entered value is not an attribute which exists on this graph.
2 | Entered value is not an integer.
2 | Error converting %s to boolean
2 | Error converting %s to byte
2 | Error converting %s to char
2 | Error converting %s to double
2 | Error converting %s to float
2 | Error converting %s to int
2 | Error converting %s to long
2 | Error converting %s to short
2 | Error converting Object '%s' to GraphLabels
2 | Error converting Object '%s' to datetime
2 | Error converting boolean to %s
2 | Error converting byte to %s
2 | Error converting char to %s
2 | Error converting double to %s
2 | Error converting float to %s
2 | Error converting int to %s
2 | Error converting long to %s
2 | Error converting short to %s
2 | Error copying custom markers to graph
2 | Error getting scatter plot state:
2 | Error loading graph:
2 | Error updating number axis scale change:
2 | Expanding graph until there are no more colllisions
2 | Expected version integer, found '%s' at %s
2 | Export to Excel  Writing Sheet
2 | Filename
2 | Find & Replace
2 | FindTopComponent
2 | FirstSeen
2 | Font family is {0}
2 | Font size is {0}
2 | Foreground Icon
2 | Found closing parenthesis ) within variable.\n
2 | Gather Vertex Ids
2 | Geo.Accuracy
2 | Geo.Altitude
2 | Geo.City
2 | Geo.Country
2 | Geo.Geohash
2 | Geo.Latitude
2 | Geo.Location
2 | Geo.Longitude
2 | Geo.Precision
2 | Geo.Shape
2 | Geo.Source
2 | Geo.Type
2 | Geohash
2 | Graph Templates
2 | Graph must contain atleast one vertex to find BoundingBox
2 | HINT_VisualGraphTopComponent
2 | Heap is empty.
2 | HierarchicalControllerTopComponent
2 | Hierarchy:
2 | HistogramTopComponent
2 | If autoRanging is false, a lower and upper bound must be set.
2 | Illegal Capacity:
2 | Import definition saved to %s.
2 | ImportDelimited
2 | Incoming
2 | Information
2 | Internet
2 | Intervals
2 | Invalid Text
2 | Invalid call to private default constructor
2 | Invalid file selected
2 | Invalid record:
2 | Invalid size for label
2 | Invalid transaction type provided.
2 | Is the transaction directed?
2 | JDBCImportTopComponent
2 | JDropDownMenu Worker
2 | KTrussControllerTopComponent
2 | Key cannot be null.
2 | LBL_dirWillBe
2 | LOCALAPPDATA
2 | Label.font
2 | LastSeen
2 | LayersViewTopComponent
2 | Line Style
2 | Lower Case
2 | MM/dd/yyyy
2 | MM/dd/yyyy HH:mm:ss
2 | MSG_SaveAsTitle
2 | MSG_SelectIcon
2 | Malformed Query
2 | Manually Created
2 | MapViewTopComponent
2 | Menu/Experimental/Animations
2 | Menu/File/Import
2 | Menu/Window
2 | Merge By
2 | Merge node type %s not found.
2 | Merged
2 | Merging Rule
2 | Millis:
2 | Minute:
2 | Modified
2 | Modify Connection
2 | NamedSelectionTopComponent
2 | Nebula file
2 | No Format
2 | No type selected
2 | No_Active_Graph
2 | No_Active_Graph=<No Active Graph>
2 | Node Labels
2 | Non numeric value entered for label size
2 | NotesViewTopComponent
2 | Null element type
2 | Null exception accessing interactionGraph
2 | OFDFD_XFiles
2 | Only calculates score when both nodes are selected
2 | Opacity
2 | OpenGL version: %s\n
2 | Opening
2 | Outgoing
2 | Pallete:
2 | Parameter is Empty!
2 | Parameters
2 | PassThru selection
2 | PerspectiveBookmarkTopComponent
2 | PlaneManagerTopComponent
2 | Plugin name
2 | PluginReporterTopComponent
2 | Polygon Style
2 | Position
2 | Properties
2 | QualityControlViewTopComponent
2 | Reading %s...
2 | Reading...
2 | RecordStore
2 | Remove Blazes
2 | Removed
2 | Removed AttributeCountMonitor, count is {0}\nMonitors are: {1}
2 | Rename
2 | Renderer: %s\n
2 | Reset View
2 | ReturnOfCollectionOrArrayField
2 | Running tab: %s
2 | SHA-256
2 | Save %s script
2 | Save As...
2 | Save Results
2 | Scatter Plot
2 | ScatterPlotTopComponent
2 | Schema Types:
2 | SchemaViewTopComponent
2 | Script interrupted by user
2 | ScriptingViewTopComponent
2 | Second:
2 | Select Blazes
2 | Select Dimmed
2 | Select Loops
2 | Select Rule Priorities
2 | Select Undimmed
2 | Select a Merge By option.
2 | Select a plugin
2 | Select on Graph
2 | SelectAllPlugin
2 | SelectedOnly
2 | SelectedOnly=Arrange only selected nodes
2 | Set Default
2 | Shader Error
2 | Shading language version: %s\n
2 | Shortcuts
2 | Show All
2 | Show all schema attributes
2 | Show on Startup
2 | SimpleGraphTopComponent
2 | SizeElementsPlugin.reset
2 | Source channel does not have the dimensions provided.
2 | Specified target is not an IntBuffer
2 | StartTime
2 | String for graph label has wrong number of fields:
2 | Substring
2 | Successfully added in
2 | Target channel is smaller than source channel.
2 | Template %s does not exist
2 | The Id of the graph
2 | The Infomap cluster color
2 | The Infomap cluster this node belongs to
2 | The URL link to the content
2 | The author of the content
2 | The character count excluding spaces
2 | The chinese whispers cluster color
2 | The company authoring the content
2 | The description of the content
2 | The dimention being 2D or 3D. The default is 2 for 2D.
2 | The last author of the content
2 | The layers currently enabled for display
2 | The line count excluding spaces
2 | The list of definitions that extend ImportDefinition
2 | The name of the file
2 | The page count of the document
2 | The permission level for the content
2 | The rule deciding how attributes are merged
2 | The size of the file
2 | The template used to create the document
2 | The title of the content
2 | The type of the file e.g .jpeg, .html
2 | The type of the file e.g JPEG, HTML
2 | The vendor of the application
2 | The version number of the content
2 | The vertex id of the node to set a blaze
2 | There must be a named selection to specify the tree roots
2 | Too many background icons: %d > %d
2 | Too many foreground icons: %d > %d
2 | Top Level Type
2 | Transactions
2 | Type Name:
2 | Type in missing fields.
2 | UncollidePlugin
2 | UncollidePlugin=Uncollide
2 | Undefined colour for blaze.
2 | Undefined colour for label.
2 | Unrecognised destination '%s'
2 | Update Template Menu
2 | Updated AttributeValueMonitor, count is {0}
2 | User-Agent
2 | Username
2 | Value required
2 | Value too large
2 | Value too small
2 | Vendor: %s\n
2 | Vertex #
2 | Visibility
2 | Waiting For Other Plugins...
2 | WelcomeTopComponent
2 | Windows
2 | X-CONSTELLATION-SECRET
2 | You cannot add a location on a Cluster Marker.
2 | You cannot add a location on a MultiMarker.
2 | You cannot remove a graph.
2 | You cannot remove a location on a Cluster Marker.
2 | You cannot remove a location on a MultiMarker.
2 | You cannot set a location on a Cluster Marker.
2 | You cannot set a location on a MultiMarker.
2 | You must select at least one transaction type
2 | Zero Point
2 | Zoom to Selection
2 | [%s: %d; v: %d t: %d e: %d l: %d]
2 | [A-Z]{1}.*
2 | [NO DESCRIPTION]
2 | \nCaused by:
2 | \nEnsure values are surrounded with Single or Double quotes.
2 | ^[a-zA-Z][a-zA-Z0-9_]*$
2 | __enter__ {0}
2 | __exit__ {0}
2 | analytic_view_state
2 | animate
2 | application/json
2 | application/x-nebula
2 | attempting to write while reading
2 | attributeType
2 | attribute_description
2 | attribute_label
2 | attribute_mod_count
2 | attribute_name
2 | attribute_type
2 | backgroundColor
2 | backgroundGlyphIndex
2 | backgroundIconColor
2 | binComparator
2 | binFormatter
2 | binFormatterParameters
2 | binSelectionMode
2 | bounding_box
2 | center-pill
2 | class-path-extension
2 | cluster_numbers
2 | cluster_seen_before
2 | column_label
2 | connection_mode
2 | connections
2 | content
2 | context successful = {0}
2 | conversation_view_state
2 | creating context for {0}
2 | currentLowerBound
2 | currentUpperBound
2 | current_step
2 | d:%s%nc:%s
2 | dataaccess_state
2 | datetime
2 | dd/MM/yyyy
2 | dd/MM/yyyy HH:mm:ss
2 | decorators
2 | default_value
2 | deflate
2 | dimension
2 | dimensions
2 | directionMotion
2 | draw_flags
2 | editable
2 | exception in context: {0}
2 | exclude_elements_dimmed
2 | exclude_single_vertices
2 | first_row
2 | flexloader.type
2 | flowfile-v3
2 | gathers
2 | global_mod_count
2 | glyphImageTexture
2 | glyphInfoTexture
2 | glyphLocationData
2 | graphLocationData
2 | graph_labels_nodes
2 | graph_labels_transactions
2 | graph_name
2 | group '%s'
2 | heightScalingFactor
2 | hierarchy
2 | histogram_state
2 | http_method
2 | image/png
2 | image_height
2 | image_width
2 | in doGet
2 | incoming
2 | incompatible with CONSTELLATION.\n\n
2 | incomplete
2 | interactive
2 | keep-alive
2 | label color
2 | layerAttributes
2 | layer_bitmask_selected
2 | layer_mask
2 | layer_visibility
2 | layers_view_state
2 | logMessage
2 | long_or_null
2 | look_at_centre
2 | look_at_eye
2 | look_at_previous_centre
2 | look_at_previous_eye
2 | look_at_previous_rotation
2 | look_at_previous_up
2 | look_at_rotation
2 | look_at_up
2 | lowerBound
2 | make graph interactable
2 | merge_step
2 | merge_type
2 | mix_color
2 | mix_ratio
2 | modules/ext/data/
2 | modules/ext/icons/003f.png
2 | netbeans.openfile.197063
2 | new_graph
2 | no cluster
2 | notes_view_state
2 | opacity
2 | org.openide.actions.CopyAction
2 | org.openide.actions.CutAction
2 | org.openide.actions.DeleteAction
2 | org.openide.actions.FileSystemAction
2 | org.openide.actions.OpenAction
2 | org.openide.actions.PropertiesAction
2 | org.openide.actions.RenameAction
2 | org.openide.actions.SaveAsTemplateAction
2 | org.openide.actions.ToolsAction
2 | org/netbeans/modules/autoupdate/ui/info_icon.png
2 | outgoing
2 | overlay_color
2 | overridden_type
2 | panelNoGraph
2 | parentheses must be used in pairs to enclose variables.
2 | pixelDensity
2 | plane_ref
2 | plugin
2 | pluginList
2 | pluginLists
2 | properties
2 | questions
2 | r=%s g=%s b=%s a=%s
2 | rawtypes
2 | reading from finished lock
2 | redraw_count
2 | referenced
2 | replace
2 | rounded
2 | scatter_plot_state
2 | schema_init
2 | schemaview-highlight-blue
2 | server.com
2 | service
2 | shaders/Graph.fs
2 | shaders/Label.fs
2 | shaders/Label.gs
2 | shaders/Line.vs
2 | shaders/PassThruLine.gs
2 | shaders/PassThruTriangle.gs
2 | single_step
2 | structure_mod_count
2 | table_view_state
2 | the maximum value
2 | the minimum value
2 | they could also indicate errors in the data.
2 | tickLabelFormatter
2 | titled-pane-heading
2 | transactionColumnAttributes
2 | transactionLayers
2 | transaction_type
2 | transaction_types
2 | translator
2 | translator_args
2 | undirected
2 | upperBound
2 | user.dir
2 | vLightPos
2 | vNormal
2 | versionedItems
2 | vertexColumnAttributes
2 | vertexLayers
2 | vertex_pasted
2 | visibility: hidden;
2 | visibility_high
2 | visibility_low
2 | visibility_value
2 | visibility_width
2 | what's new
2 | widthScalingFactor
2 | wrapped
2 | you are here
2 | yyyy-MM-dd'T'HH:mm:ss'Z'
2 | yyyy-MM-dd'T'HH:mm:ss.SSS'Z'
2 | yyyy-mm-dd
2 | yyyyMMdd
2 | yyyyMMdd HHmmss'Z'
2 | yyyyMMddHHmmss
2 | {0} is higher than the maximum ({1}) allowed. Changing to
2 | {0} is lower than the minimum ({1}) allowed. Changing to
2 | multiple selection

antares1470 commented 2 years ago

I think I would be careful about the approach to this. It probably would be worth sharing some more constants across the application but what the raw numbers don't provide is context. For example "LOW LEVEL" is being used as a plugin tag so it might make more sense to consolidate all the plugin tags into their own constants class rather than dumping it into a large catch all strings constants class.

There might also be examples of strings that while having the same value are used in a number of different contexts and so it might be better to separate those contexts out rather than using one value that all contexts use.

There are probably other examples of that as well so based on that I think creating a series of contextual constant classes would be the best option here (rather than one catch-all)

antares1470 commented 2 years ago

I would also propose not bothering with extracting any only used a couple of times. I think we should only consolidate strings into constants if we think it's going to be helpful in the long run (even Sonar doesn't care about strings only used a couple of times)

CrucisGamma commented 2 years ago

data_for_duplicates2.txt (This was specifically excluding strings related to any unit test java files)

arcturus2 commented 2 years ago

Thanks @CrucisGamma. This will be handy for things I wanted to do like looking for spelling errors and identify inconsistencies. Cheers.

CrucisGamma commented 2 years ago

Thanks @CrucisGamma. This will be handy for things I wanted to do like looking for spelling errors and identify inconsistencies. Cheers.

I'd agree @arcturus2 . A part of this goes back to inconsistenciies in the UX that is jarring for the user once noticed. For example the issue of OK vs Ok (25 individual copies of "OK" throughout the code). (spelling error was deliberate ;))

aldebaran30701 commented 2 years ago

PluginTags class was created within #1555 and should partially address this.