Alter functions in Utility classes to throw exceptions rather than catch

antares1470 commented 3 years ago

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:
- Running the latest version of Constellation
- Attached the Support Package via Help > Support Package
- Checked the FAQs: https://github.com/constellation-app/constellation/wiki/FAQ
- Checked that your issue isn’t already filed: https://github.com/constellation-app/constellation/issues
- Checked that there is not already a module that provides the described functionality: https://github.com/constellation-app/constellation/wiki/Catalogue-of-Repositories

Description

Utility functions are designed to be able to be used in multiple different situations. Consequently when an exception occurs, the likely trigger for said exception type may differ depending on the situation the function is called in.

In order to allow for these different situations, the exceptions should be thrown from the utility function rather than caught. This leaves the exception handling then to where the function was called, allowing it to be handled more meaningfully with respect to the situation (e.g. a more meaningful error message for users) rather than constructing a generic response (which would need to happen if caught in the utility function itself).

Expected behaviour: All utility functions throw all their exceptions and catch none

Actual behaviour: Some utility functions catch at least one of their exceptions

Reproduces how often: ? (wasn't going to calculate the % of utility functions catching exceptions but there are some in there)